Correctly centering text on rectangular devices#85
Merged
hatl merged 1 commit intohatl:masterfrom Jul 20, 2025
Merged
Conversation
alexpetroaica
commented
Jul 8, 2025
| if (Utils.isRectangularScreen()) { | ||
| dc.setColor(Graphics.COLOR_WHITE, Graphics.COLOR_BLACK); | ||
| dc.drawText(vh * 0.65, cvw, font, text, Graphics.TEXT_JUSTIFY_CENTER); | ||
| dc.drawText(cvw, vh * 0.4, font, text, Graphics.TEXT_JUSTIFY_CENTER); |
Author
There was a problem hiding this comment.
According to the docs, the width is the first argument, not the height, which was causing some trouble (see screenshots i added to the PR)
alexpetroaica
commented
Jul 8, 2025
| dc.drawText(cvw, vh * 0.4, font, text, Graphics.TEXT_JUSTIFY_CENTER); | ||
| } else { | ||
| dc.setColor(Graphics.COLOR_WHITE, Graphics.COLOR_BLACK); | ||
| dc.drawText(cvh, cvw, font, text, Graphics.TEXT_JUSTIFY_CENTER); |
Author
There was a problem hiding this comment.
I didn't want to touch this one because I assumed you tested on non-rectangular devices, but it should probably be fixed too as the arguments are passed the wrong way around
Owner
|
Thank you for your contributions! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hatl
approved these changes
Jul 20, 2025
Salvio93
pushed a commit
to Salvio93/hasscontrol
that referenced
this pull request
Jan 4, 2026
Authored-by: alexpetroaica <!alexandru.petroaica@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEFORE:
AFTER:
